-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused leftover files #551
Conversation
fixes #490 The relevant changes needed are: pinging the aiida-pseudo version. Refactoring the methods in setup_pseudos.py to support flexible parameter passing. Note that from the test all 8 pseudos seems to only save ~10s but in the place where the network condition is bad, this is very helpful. --------- Co-authored-by: superstar54 <xingwang1991@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #551 +/- ##
=======================================
Coverage 80.73% 80.73%
=======================================
Files 49 49
Lines 3415 3415
=======================================
Hits 2757 2757
Misses 658 658
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Ah, sorry, it was caused by I forced commit to update the commit message yesterday. Should be fine now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is definitely old stuff, just go ahead 👍
I guess these files were not used for quite a while, some are needed to run it through the binder, but we don't have a plan to support it anymore I assume? Pining @yakutovicha for comment, you are the only one who has a picture of the history of the app from its birth.